Skip to content

Conversation

@Repiteo
Copy link
Contributor

@Repiteo Repiteo commented Oct 6, 2025

In practice, this changes nothing, as CPPEXTPATH was never utilized here. However, with this being reverted in the above repo, this necessitates use of error macro wrappers to handle suppression instead. Those were never properly ported over here, so this PR adds them as well.

@Repiteo Repiteo requested a review from a team as a code owner October 6, 2025 18:50
@Repiteo Repiteo added bug This has been identified as a bug waiting for Godot PRs that can't be merged until an engine PR is merged first regression topic:buildsystem Related to the buildsystem or CI setup cherrypick:4.5 and removed waiting for Godot PRs that can't be merged until an engine PR is merged first labels Oct 6, 2025
@Repiteo Repiteo requested a review from dsnopek October 9, 2025 14:24
Copy link
Collaborator

@dsnopek dsnopek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks good to me :-)

@dsnopek dsnopek merged commit 647c7d8 into godotengine:master Oct 20, 2025
16 checks passed
@dsnopek
Copy link
Collaborator

dsnopek commented Oct 20, 2025

Cherry-picked for 4.5 in PR #1870

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug This has been identified as a bug regression topic:buildsystem Related to the buildsystem or CI setup

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants